Conversation
|
didn't check everything just briefly skimmed through, but already few questions:
|
|
Hey, I did not actually publish anything yet, just let it run through once to check if all works with the newest version, thus the versions also have not alpha beta or anything applied to them. Would revert/rerun the publish again once it is ready |
9a41d9c to
b6a9608
Compare
b6a9608 to
2dd3783
Compare
|
Hey @deathmaz @kalievsky, will you guys have some time to check this soon? |
|
Hi @ChristianPraiss cannot promise when exactly but will check at some point, want to also test it in one of my projects. Have you tried it on real projects on your side? |
deathmaz
left a comment
There was a problem hiding this comment.
- Stylelint also was bumped few major version but i cannot verify if it still works fine as I'm not using it any more
- some of the packages can be updated again since this PR was created
- not yet tested in real project
packages/vue-form-validator/src/form-validator/utils/is-valid-url.ts
Outdated
Show resolved
Hide resolved
- Added `globals` package to ESLint config for better global variable management. - Updated dependencies in `eslint-config-convidera`, `eslint-config-ts-convidera`, and `eslint-config-vue3-convidera` to the latest versions. - Adjusted ESLint rules and configurations for improved code quality and consistency. - Removed deprecated or unnecessary configurations in ESLint setup. This update enhances the linting process and ensures compatibility with the latest ESLint features.
…pport - Added support for `.mts` and `.mjs` file extensions in ESLint configurations for both utils and vue-form-validator packages. - Simplified the linting command in package.json files to use default extensions. This update improves linting capabilities for modern JavaScript and TypeScript file formats.
- Added support for `defineOptions`, `defineSlots`, and `defineModel` as readonly properties in the ESLint configuration for Vue 3. This update enhances linting capabilities for Vue 3 features, ensuring better code quality and consistency.
|
Soo, I updated it and gave it a round of testing. It's a slight bit stricter overall (tested on https://github.com/convidera/partnerlink), reporting some no-unused-vars and no-explicit-any warnings, but i guess those are very valid rules anyway. @jhoefker @deathmaz. |
|
@ChristianPraiss i tried it on my project and in some places eslint reported errors where it shouldn't: in all const emit = defineEmits<{(e: 'close'): void,
(e: 'success', payload: AppDataTaskApplicationFeedFeedItemResource): void
}>();things like const emit = defineEmits<{
close: [],
success: [payload: AppDataTaskApplicationFeedFeedItemResource]
}>();Because those are not errors and the syntax is a valid vue3 syntax, imo it's better to not report those things as errors if possible. The rest of the reported issues i got mostly about no-explicit-any, which if needed could be changed on per project basis and i'm fine with it |
|
Hey, thx for testing it out! Will check what can be done about the rule, will see if there is a vue-specific version or if the rule params have an option to fix this. |

TODOS: